Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGPU queries refactor #2041
GPU queries refactor #2041
Conversation
|
I didn't get to this today, sorry - will do first thing in the morning. It looks great so far from a quick scan though! CI failures:
|
|
(We probably need to update both the travis.yml and the taskcluster config) |
|
Reviewed 12 of 14 files at r1. webrender/src/profiler.rs, line 882 at r1 (raw file):
Should we remove this or comment it perhaps? Comments from Reviewable |
|
(Partial review of the easy bits so far - will cover the remaining files in the morning). |
|
Reviewed 2 of 14 files at r1, 3 of 3 files at r2. Comments from Reviewable |
|
Looks good, thanks! |
|
I noticed that when I toggle the query feature on and off, a small box occurs in the top left of the screen - it looks like perhaps the quad for the profile counters is still being drawn? Not a big deal anyway - we can fix that as a follow up if you like. So, r=me - I'll leave it to you to squash / fix that bug if you want to, or merge now :) |
|
Thanks @glennw ! Fix appeared to be rather trivial: 19731c1#diff-59bdb33ab120f3af70ac6ca84fd5451fR882 @bors-servo r=glennw |
|
|
GPU queries refactor Removes `query` compile feature. Fixes #1994 Refactors the GPU queries quite a bit, including moving the logic into a dedicated module. Ideally should be tested on Android, but we can patch it afterwards anyway. Note: the API is asking for some type-level protection against: - doing anything outside of frame bounds - starting to sample queries in a row But I don't see a way to make it stronger without introducing obscure programming patterns :) So I'm leaving it with just start/finish semantics, plus a bit of RAII. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2041) <!-- Reviewable:end -->
|
|
19731c1
into
servo:master
|
@kvark This caused webrender to crash on windows, see https://bugzilla.mozilla.org/show_bug.cgi?id=1417062#c5 |
Query GL assertion removal Fixes #2041 (comment) r? anyone <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2049) <!-- Reviewable:end -->
kvark commentedNov 15, 2017
•
edited by larsbergstrom
Removes
querycompile feature. Fixes #1994Refactors the GPU queries quite a bit, including moving the logic into a dedicated module.
Ideally should be tested on Android, but we can patch it afterwards anyway.
Note: the API is asking for some type-level protection against:
But I don't see a way to make it stronger without introducing obscure programming patterns :) So I'm leaving it with just start/finish semantics, plus a bit of RAII.
This change is