Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lifetime parameter of Renderer #2064

Merged
merged 1 commit into from Nov 21, 2017
Merged

Remove lifetime parameter of Renderer #2064

merged 1 commit into from Nov 21, 2017

Conversation

@sotaroikeda
Copy link
Contributor

sotaroikeda commented Nov 20, 2017 •
edited

In #2032, @glennw commented about the problem about lifetime parameter of Renderer. The lifetime parameter could cause a problem to merge to Servo. This pull request addresses it. There could be another ways to address the problem.

cc @glennw @kvark

This change is Reviewable
@kvark
kvark approved these changes Nov 20, 2017
View changes
Copy link
Member

kvark left a comment

Looks good. Leaving for @glennw to confirm his concerns are addressed :)
wrench/src/rawtest.rs Outdated
wrench,
rx,
window,
wrench: wrench,

This comment has been minimized.

Sign in to view
@kvark

kvark Nov 20, 2017

Member

this should be unnecessary
@glennw
Copy link
Member

glennw commented Nov 20, 2017

Thanks! Looks good to me once the nit from @kvark above is fixed.
@sotaroikeda
Remove lifetime parameter from Renderer
Loading status checks…
0199800
@sotaroikeda sotaroikeda force-pushed the sotaroikeda:rm-lifeparam branch from 93f55bd to 0199800 Nov 20, 2017
@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Nov 20, 2017 •
edited

Applied the comment!
@glennw
Copy link
Member

glennw commented Nov 21, 2017

Thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2017

📌 Commit 0199800 has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2017

⌛ Testing commit 0199800 with merge 9838626...
bors-servo added a commit that referenced this pull request Nov 21, 2017
@bors-servo
Auto merge of #2064 - sotaroikeda:rm-lifeparam, r=glennw
Loading status checks…
9838626 
Remove lifetime parameter of Renderer

In #2032, @glennw commented about the problem about lifetime parameter of Renderer. The lifetime parameter could cause a problem to merge to Servo.  This pull request addresses it. There could be another ways to address the problem.

cc @glennw @kvark

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2064)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Nov 21, 2017
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: glennw
Pushing 9838626 to master...
@bors-servo bors-servo merged commit 0199800 into servo:master Nov 21, 2017
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@sotaroikeda sotaroikeda deleted the sotaroikeda:rm-lifeparam branch Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@sotaroikeda @glennw @bors-servo @kvark
You can’t perform that action at this time.