Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fixed layer per iframe #207

Merged
merged 1 commit into from Mar 1, 2016
Merged

Conversation

@glennw
Copy link
Member

glennw commented Feb 29, 2016

No description provided.

@@ -1119,6 +1142,21 @@ impl Frame {
if let Some(root_scroll_layer_id) = self.root_scroll_layer_id {
self.update_layer_transform(root_scroll_layer_id, &Matrix4::identity());
}

// Updated any fixed layers

This comment has been minimized.

@pcwalton

pcwalton Feb 29, 2016

Collaborator

typo: "update"

@pcwalton
Copy link
Collaborator

pcwalton commented Feb 29, 2016

One typo, otherwise looks good

@glennw glennw force-pushed the glennw:fixed-layers branch from 0557419 to 0a784c6 Feb 29, 2016
@glennw
Copy link
Member Author

glennw commented Mar 1, 2016

@bors-servo r=pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

📌 Commit 0a784c6 has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

Testing commit 0a784c6 with merge 58caf12...

bors-servo added a commit that referenced this pull request Mar 1, 2016
Support for fixed layer per iframe
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

💔 Test failed - travis

@glennw glennw force-pushed the glennw:fixed-layers branch from 0a784c6 to 4dea3fe Mar 1, 2016
@glennw
Copy link
Member Author

glennw commented Mar 1, 2016

@metajack re-r? (Just rebased, and updated the temporary cargo.lock file).

@metajack
Copy link

metajack commented Mar 1, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

📌 Commit 4dea3fe has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

Testing commit 4dea3fe with merge f8bb08e...

bors-servo added a commit that referenced this pull request Mar 1, 2016
Support for fixed layer per iframe
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 4dea3fe into servo:master Mar 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@glennw glennw deleted the glennw:fixed-layers branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.