Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upResize uvs when growing textures. #208
Merged
+37
−48
Conversation
src/texture_cache.rs
Outdated
| item.texture_size.height as f32; | ||
| item.texture_size = Size2D::new(texture_size, texture_size); | ||
|
|
||
| item.uv_rect.top_left.x /= width_factor; |
This comment has been minimized.
This comment has been minimized.
glennw
Feb 29, 2016
Member
@pcwalton Is this going to introduce float accuracy issues after a number of resizes? Should we directly recalculate from the pixel rect each time instead?
|
@glennw r? |
Fixes browser.html.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 29, 2016
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 1, 2016
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedFeb 29, 2016
Fixes browser.html.
r? @glennw