Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Core Text to render fonts on the Mac. #21
Merged
+200
−15
Conversation
|
Needs servo/core-text-rs#43 and servo/core-graphics-rs#43 to land first |
|
@pcwalton Looks good - let me know when it's ready to merge. |
|
Updated patch now hands Core Graphics font handles from Servo over to WebRender directly, allowing Helvetica to work. |
|
Have the dependent patches landed now, is this ready for merge? |
|
Oh it looks like one is open still. |
pcwalton
force-pushed the
pcwalton:mac-fonts
branch
3 times, most recently
from
656a5e7
to
347959b
glennw
added a commit
that referenced
this pull request
Oct 29, 2015
Use Core Text to render fonts on the Mac.
pcwalton
pushed a commit
to pcwalton/webrender
that referenced
this pull request
Jul 30, 2016
Fix colors for inset and outset border styles
nox
pushed a commit
to nox/webrender
that referenced
this pull request
Aug 6, 2016
webgl: Use offscreen_gl_context from crates.io Due to my username change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 14, 2015
Makes fonts look more platform-native and is a prerequisite for .dfont support,
which is needed to render Helvetica.