Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for basic performance annotations to reftests. #2105
+158
−22
Conversation
This basic implementation allows a reftest to optionally specifiy the expected number of draw calls, alpha targets and color targets that the test should use. This can be used for things such as: * Ensuring primitives are batching together as expected. * Ensuring that tests use the expected number of render targets. * Ensuring that invisible filters are removed. * Ensuring that certain operations (e.g. opacity) get collapsed into a more efficient rendering strategy.
|
Looks good to me! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 27, 2017
Add support for basic performance annotations to reftests. This basic implementation allows a reftest to optionally specifiy the expected number of draw calls, alpha targets and color targets that the test should use. This can be used for things such as: * Ensuring primitives are batching together as expected. * Ensuring that tests use the expected number of render targets. * Ensuring that invisible filters are removed. * Ensuring that certain operations (e.g. opacity) get collapsed into a more efficient rendering strategy. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2105) <!-- Reviewable:end -->
|
|
|
@staktrace Heads up that you'll need to change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedNov 27, 2017
•
edited by larsbergstrom
This basic implementation allows a reftest to optionally specifiy
the expected number of draw calls, alpha targets and color targets
that the test should use.
This can be used for things such as:
into a more efficient rendering strategy.
This change is