Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some redundant cases of clip mask generation. #2115

Merged
merged 1 commit into from Nov 28, 2017

Commits on Nov 28, 2017

  1. Fix some redundant cases of clip mask generation.

    There are two fixes here:
     * Image pictures were generating clip masks, but they are never
       actually used. In the future, we *might* want to support this,
       but at the moment it just results in clip masks that are then
       never used.
     * If a primitive is in the root coordinate system, then we know
       that it is axis-aligned, and that there are no coordinate
       system changes in between this primitive and the root. In that
       case, we can infer that the local_clip_rect of the clip scroll
       node will correctly handle the screen space clip rect.
    
    In Gecko with the current WR code, I was seeing a lot of very large
    clip masks being generated (4x extra A8 render targets) on HN. The
    test case included here is a very reduced test case for these issues.
    
    The test case makes use of the new reftest annotations to assert
    that no alpha targets get allocated while rendering the yaml file.
    gw3583 committed Nov 28, 2017
You can’t perform that action at this time.