Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix loop count from 7b9c8e638 #214
Merged
+1
−1
Conversation
After updating WebRender, [this box shadow][1] rendered incorrectly. `git bisect` pointed to 7b9c8e6, where I noticed that the replacement code wasn't quite equivalent -- `self.vertices` vs `vertices` [1]: https://github.com/kevinmehall/webrender- experiments/blob/master/src/main.rs#L127
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 1, 2016
Fix loop count from 7b9c8e6 After updating WebRender, [this box shadow](https://github.com/kevinmehall/webrender-experiments/blob/master/src/main.rs#L127) rendered incorrectly. `git bisect` pointed to 7b9c8e6, where I noticed that the replacement code wasn't quite equivalent -- `self.vertices` vs `vertices` Before:  After: 
|
Thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinmehall commentedMar 1, 2016
After updating WebRender, this box shadow rendered incorrectly.
git bisectpointed to 7b9c8e6, where I noticed that the replacementcode wasn't quite equivalent --
self.verticesvsverticesBefore:
After: