Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next set of ClipScrollTree optimizations #2156

Merged
merged 4 commits into from Dec 4, 2017
+246 −326
Merged

Next set of ClipScrollTree optimizations #2156

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9f2b7d
Refactor ClipScrollTree::update
mrobinson Dec 1, 2017
41c5eb1
Use transform_rect in prim_store.rs
mrobinson Dec 1, 2017
1751ecc
Extract bounding rect calculation from TransformedRect
mrobinson Dec 1, 2017
2901a69
Remove some unused code from util.rs
mrobinson Dec 4, 2017
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Refactor ClipScrollTree::update 

Rework ClipScrollTree::update, eliminated members which are now
duplicated in ClipScrollNodeData and reducing the amount of unnecessary
work. There are a few main thrusts here:

1. Don't do matrix operations if it's not necessary.
Transform3D::pre_mul was showing up in CPU profiles, and this makes it
much less significant.
2. Don't spend time setting up state if we are not going to recurse.
3. When we encounter an empty node (including those clipped out), do as
little as possible. This includes setting update state or calculating
things for ClipScrollNodeData.
  • Loading branch information
@mrobinson
mrobinson committed Dec 4, 2017
commit f9f2b7df9437be76fc9cec1c186f1d5e2ce36d44
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.