Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix handling of embedded bitmaps in FreeType font backend #2164
Conversation
|
@bors-servo: r+ |
|
|
|
@bors-servo p=1 |
|
Can we get a test? |
bors-servo
added a commit
that referenced
this pull request
Dec 5, 2017
fix handling of embedded bitmaps in FreeType font backend This fixes a small regression I accidentally made with #2120. The prior "(flags & FONT_EMBEDDED_BITMAP) == 0" statement needed to be !contains() rather than just contains(). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2164) <!-- Reviewable:end -->
|
@jrmuizel We would need at least a appropriately licensed bitmap font we could include in the tree to test that sort of thing. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lsalzman commentedDec 5, 2017
•
edited by larsbergstrom
This fixes a small regression I accidentally made with #2120. The prior "(flags & FONT_EMBEDDED_BITMAP) == 0" statement needed to be !contains() rather than just contains().
This change is