Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for overscrolling on the Mac. #217

Merged
merged 1 commit into from Mar 4, 2016

Conversation

@pcwalton
Copy link
Collaborator

pcwalton commented Mar 3, 2016

This generalizes scroll info to a separate structure, which paves the
way toward supporting zoom as well.

r? @glennw
cc @paulrouget

@glennw
Copy link
Member

glennw commented Mar 3, 2016

@pcwalton This looks good to me - will need a rebase.

@pcwalton pcwalton force-pushed the pcwalton:overscroll branch 2 times, most recently from b21ab71 to b2cd736 Mar 4, 2016
This generalizes scroll info to a separate structure, which paves the
way toward supporting zoom as well.
@glennw
Copy link
Member

glennw commented Mar 4, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

📌 Commit b2cd736 has been approved by glennw

@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

Testing commit b2cd736 with merge f299539...

bors-servo added a commit that referenced this pull request Mar 4, 2016
Implement support for overscrolling on the Mac.

This generalizes scroll info to a separate structure, which paves the
way toward supporting zoom as well.

r? @glennw
cc @paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit b2cd736 into servo:master Mar 4, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@pcwalton pcwalton deleted the pcwalton:overscroll branch Mar 4, 2016
bors-servo added a commit to servo/servo that referenced this pull request Mar 10, 2016
Implement support for overscrolling on the Mac.

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9851)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Mar 11, 2016
Implement support for overscrolling on the Mac.

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9851)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Mar 11, 2016
Implement support for overscrolling on the Mac.

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9851)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Mar 11, 2016
Implement support for overscrolling on the Mac.

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9851)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Mar 11, 2016
Implement support for overscrolling on the Mac.

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9851)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Mar 12, 2016
Implement support for overscrolling on the Mac.

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9851)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Mar 12, 2016
Implement support for overscrolling on the Mac.

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9851)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Mar 14, 2016
Implement support for overscrolling on the Mac.

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9851)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Mar 14, 2016
Implement support for overscrolling on the Mac.

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9851)
<!-- Reviewable:end -->
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…from pcwalton:overscroll); r=glennw

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

Source-Repo: https://github.com/servo/servo
Source-Revision: 881d6b4220f2391a22d4ea73b79415071626501f

UltraBlame original commit: 7144390c4be6c297f922ce7cd38c6f3f1eff78c1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…from pcwalton:overscroll); r=glennw

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

Source-Repo: https://github.com/servo/servo
Source-Revision: 881d6b4220f2391a22d4ea73b79415071626501f

UltraBlame original commit: 7144390c4be6c297f922ce7cd38c6f3f1eff78c1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…from pcwalton:overscroll); r=glennw

Requires rust-windowing/glutin#734, servo/webrender_traits#14, and
servo/webrender#217.

r? whoever (waiting on the landing of the above)

Source-Repo: https://github.com/servo/servo
Source-Revision: 881d6b4220f2391a22d4ea73b79415071626501f

UltraBlame original commit: 7144390c4be6c297f922ce7cd38c6f3f1eff78c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.