Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDefine and enforce BLOCKS_PER_UV_RECT #2212
Conversation
|
|
|
Funny thing... in an attempt to get a try push with this change I figured I can just fetch the code from failed try pushes of @staktrace , fix it, and push again. What a mistake! Git-cinnabar-powered fetch went OOM on my 8gb RAM laptop after an hour of operation, with all apps except that console window closed... |
|
Looks good, r=me. I'll leave it to you if you want to do a try push, but it doesn't seem necessary for this patch, I think. |
|
Now that #2211 is merged this PR doesn't change any logic, hence safe to merge. |
|
|
Define and enforce BLOCKS_PER_UV_RECT A stronger version of the fix for #2208 Replaces #2211 TODO: try push Note: I tried going all the way to type-level enforcement of the GPU block count for everything but faced a few run-time driven GPU layouts (clip sources, borders). Perhaps, next time... <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2212) <!-- Reviewable:end -->
|
|
kvark commentedDec 10, 2017
•
edited by larsbergstrom
A stronger version of the fix for #2208
Replaces #2211
TODO: try push
Note: I tried going all the way to type-level enforcement of the GPU block count for everything but faced a few run-time driven GPU layouts (clip sources, borders). Perhaps, next time...
This change is