Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed transformed primitives #2217
Merged
Conversation
|
Oops! r=me if try is green. |
|
Test case?
…On Dec 12, 2017 10:02 AM, "Glenn Watson" ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2217 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUTbVXAFalv31Xerj3v0cOc2v4p6cImks5s_qOcgaJpZM4Q_MfJ>
.
|
|
@jrmuizel I think we don't have support for different dpi ratio tests in wrench yet. But you're right, we should open an issue to support this and add a test as a follow up. |
|
All green. |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 12, 2017
Fixed transformed primitives Fixes #2168 Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e446306f491bf773f335469280f0b3db412ffa9f <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2217) <!-- Reviewable:end -->
|
@bors-servo r- |
|
@bors-servo r=glennw |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 12, 2017
Fixed transformed primitives Fixes #2168 Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e446306f491bf773f335469280f0b3db412ffa9f <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2217) <!-- Reviewable:end -->
|
|
|
OSX:
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 13, 2017
Fixed transformed primitives Fixes #2168 Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e446306f491bf773f335469280f0b3db412ffa9f <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2217) <!-- Reviewable:end -->
|
|
|
Hmm, have our OSX build times regressed? |
bors-servo
added a commit
that referenced
this pull request
Dec 13, 2017
Fixed transformed primitives Fixes #2168 Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e446306f491bf773f335469280f0b3db412ffa9f <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2217) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedDec 12, 2017
•
edited
Fixes #2168
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e446306f491bf773f335469280f0b3db412ffa9f
This change is