Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix overlapping border radii handling. #2228
Merged
Conversation
| ellipse_center_radius.zw, | ||
| aa_range); | ||
|
|
||
| return max(distance, current_distance); |
This comment has been minimized.
This comment has been minimized.
kvark
Dec 15, 2017
Member
the semantics of current_distance is not clear to me. Shouldn't this be min(distance, current_distance)?
This comment has been minimized.
This comment has been minimized.
glennw
Dec 15, 2017
Author
Member
We want to take the maximum distance, so that if any of the active clip regions results in clipping the primitive out, it removes it.
|
Try looks green for this PR. |
|
thanks for explanation! |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 15, 2017
Fix overlapping border radii handling. This ensures that the shader takes the max clipped distance from each active clip region, which fixes this bug. Additionally, apply the CSS spec radius clamping to clip rects. This makes the results in the clip/clip-ellipse reftest match Gecko, so I updated the reference image. Fixes #2174. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2228) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedDec 15, 2017
•
edited by larsbergstrom
This ensures that the shader takes the max clipped distance
from each active clip region, which fixes this bug.
Additionally, apply the CSS spec radius clamping to clip rects.
This makes the results in the clip/clip-ellipse reftest match
Gecko, so I updated the reference image.
Fixes #2174.
This change is