Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure that we update the epoch of images so that we don't redraw them. #2240
Conversation
|
@mstange this fixes a constant redrawing bug that I ran into with the current blob image invalidation code. |
|
Great to have a fix as well as a new test! |
| ); | ||
|
|
||
| let mut builder = DisplayListBuilder::new(self.wrench.root_pipeline_id, layout_size); | ||
| builder.push_image( |
This comment has been minimized.
This comment has been minimized.
| self.wrench | ||
| .api | ||
| .generate_frame(self.wrench.document_id, None); | ||
| self.submit_dl(&mut Epoch(0), layout_size, builder, None); |
This comment has been minimized.
This comment has been minimized.
jrmuizel
force-pushed the
jrmuizel:update-template
branch
2 times, most recently
from
5c3ed1c
to
5ae2273
|
yes! |
|
|
Ensure that we update the epoch of images so that we don't redraw them. This cleans up the rawtests a little, adds the ability to track blob image requests, adds a test to make sure that we don't request unnecessarily and fixes the test. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2240) <!-- Reviewable:end -->
|
|
|
|
|
Needs a (small) rebase. |
|
@bors-servo r+ |
|
|
Ensure that we update the epoch of images so that we don't redraw them. This cleans up the rawtests a little, adds the ability to track blob image requests, adds a test to make sure that we don't request unnecessarily and fixes the test. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2240) <!-- Reviewable:end -->
|
|
jrmuizel commentedDec 19, 2017
•
edited by larsbergstrom
This cleans up the rawtests a little, adds the ability to track blob image requests, adds a test to make sure that we don't request unnecessarily and fixes the test.
This change is