Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend segment building to handle clip in/out, multiple clip regions. #2242

Merged
merged 4 commits into from Dec 20, 2017
Merged

Extend segment building to handle clip in/out, multiple clip regions. #2242

merged 4 commits into from Dec 20, 2017
+1,099 −399

Commits on Dec 20, 2017

  1. Extend segment building to handle clip in/out, multiple clip regions. 

    Introduce segment builder, which is able to handle a much larger
range of clip scenarios than the initial segment implementation.

Instead of only handling the simple case of a single nine-patch
clip, we can now handle any number of local clip regions, and most
importantly, both clip and clip out modes. The support for clip-out
means we can often eliminate large areas of internal pixels for
items such as box-shadows. Note: the box-shadow code is not currently
hooked up to take advantage of this yet.

In the future, the segment builder can quite easily be extended to
handle the remaining clip sources that aren't handled - the image
mask and border corner clip sources.
    @gw3583
    gw3583 committed Dec 20, 2017
    fdac230

  2. Fix borders with pre-built segments not checking clip mask kind.

    @gw3583
    gw3583 committed Dec 20, 2017
    479e48f

  3. Adding edge flags to unit tests

    @gw3583
    gw3583 committed Dec 20, 2017
    Loading status checks…
    6ef9d02

  4. Address review comments

    @gw3583
    gw3583 committed Dec 20, 2017
    Loading status checks…
    9423cf2
You can’t perform that action at this time.