Correctly handle the inset box shadow offset. #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @bors-servo r+ |
|
📌 Commit b94b57e has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 14, 2018
Correctly handle the inset box shadow offset. If the blur radius is larger than offset size, we should still see the blur on the edge. But currently, the brush will be clipped after moving. So I enlarge the brush rect and picture rect to fix this problem. It fixes gecko [bug 1429411](https://bugzilla.mozilla.org/show_bug.cgi?id=1429411). gecko try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5291c42ee1c846566c98e6a33b6b9e1270bea3c2&selectedJob=155567986 There is a failure and the fuzz value should be changed to (6,8936) from (6,8490). I think it should be fine. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2285) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 14, 2018
Correctly handle the inset box shadow offset. If the blur radius is larger than offset size, we should still see the blur on the edge. But currently, the brush will be clipped after moving. So I enlarge the brush rect and picture rect to fix this problem. It fixes gecko [bug 1429411](https://bugzilla.mozilla.org/show_bug.cgi?id=1429411). gecko try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5291c42ee1c846566c98e6a33b6b9e1270bea3c2&selectedJob=155567986 There is a failure and the fuzz value should be changed to (6,8936) from (6,8490). I think it should be fine. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2285) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 15, 2018
Correctly handle the inset box shadow offset. If the blur radius is larger than offset size, we should still see the blur on the edge. But currently, the brush will be clipped after moving. So I enlarge the brush rect and picture rect to fix this problem. It fixes gecko [bug 1429411](https://bugzilla.mozilla.org/show_bug.cgi?id=1429411). gecko try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5291c42ee1c846566c98e6a33b6b9e1270bea3c2&selectedJob=155567986 There is a failure and the fuzz value should be changed to (6,8936) from (6,8490). I think it should be fine. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2285) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Jan 15, 2018
Correctly handle the inset box shadow offset. If the blur radius is larger than offset size, we should still see the blur on the edge. But currently, the brush will be clipped after moving. So I enlarge the brush rect and picture rect to fix this problem. It fixes gecko [bug 1429411](https://bugzilla.mozilla.org/show_bug.cgi?id=1429411). gecko try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5291c42ee1c846566c98e6a33b6b9e1270bea3c2&selectedJob=155567986 There is a failure and the fuzz value should be changed to (6,8936) from (6,8490). I think it should be fine. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2285) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
bors-servo
pushed a commit
that referenced
this pull request
Jan 15, 2018
Correctly handle the inset box shadow offset. If the blur radius is larger than offset size, we should still see the blur on the edge. But currently, the brush will be clipped after moving. So I enlarge the brush rect and picture rect to fix this problem. It fixes gecko [bug 1429411](https://bugzilla.mozilla.org/show_bug.cgi?id=1429411). gecko try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5291c42ee1c846566c98e6a33b6b9e1270bea3c2&selectedJob=155567986 There is a failure and the fuzz value should be changed to (6,8936) from (6,8490). I think it should be fine. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2285) <!-- Reviewable:end -->
|
Manually merging to unblock team during testing/ops issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the blur radius is larger than offset size, we should still see the blur on the edge. But currently, the brush will be clipped after moving. So I enlarge the brush rect and picture rect to fix this problem.
It fixes gecko bug 1429411.
gecko try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5291c42ee1c846566c98e6a33b6b9e1270bea3c2&selectedJob=155567986
There is a failure and the fuzz value should be changed to (6,8936) from (6,8490). I think it should be fine.
r? @glennw
This change is