Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push line primitives through normal brush code paths. #2301

Merged
merged 1 commit into from Jan 16, 2018
Merged

Push line primitives through normal brush code paths. #2301

merged 1 commit into from Jan 16, 2018

Conversation

@glennw
Copy link
Member

glennw commented Jan 14, 2018 •
edited by larsbergstrom

This change is Reviewable
@glennw
Copy link
Member Author

glennw commented Jan 14, 2018

r? @kvark

Gecko try looks good:
https://hg.mozilla.org/try/rev/70c2e0c7d8c6247ee3896cee0b21ad6a87797505
https://treeherder.mozilla.org/#/jobs?repo=try&revision=70c2e0c7d8c6247ee3896cee0b21ad6a87797505
@mrobinson
mrobinson approved these changes Jan 15, 2018
View changes
Copy link
Member

mrobinson left a comment

This change looks okay to me, but you can also wait for a review form @kvark.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 15, 2018

☔ The latest upstream changes (presumably #2290) made this pull request unmergeable. Please resolve the merge conflicts.
@gw3583
Push line primitives through normal brush code paths.
Loading status checks…
b4ff160
@glennw glennw force-pushed the glennw:line-batch branch from 0882c56 to b4ff160 Jan 15, 2018
@glennw
Copy link
Member Author

glennw commented Jan 15, 2018

@bors-servo r=mrobinson
@bors-servo
Copy link
Contributor

bors-servo commented Jan 15, 2018

📌 Commit b4ff160 has been approved by mrobinson
@kvark
Copy link
Member

kvark commented Jan 16, 2018

:lgtm: the idea of a brush shader is really paying off :)

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2018

⌛ Testing commit b4ff160 with merge cb04406...
bors-servo added a commit that referenced this pull request Jan 16, 2018
@bors-servo
Auto merge of #2301 - glennw:line-batch, r=mrobinson
Loading status checks…
cb04406 
Push line primitives through normal brush code paths.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2301)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: mrobinson
Pushing cb04406 to master...
@bors-servo bors-servo merged commit b4ff160 into servo:master Jan 16, 2018
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
code-review/reviewable 5 files reviewed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@glennw @bors-servo @kvark @mrobinson @gw3583
You can’t perform that action at this time.