Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues related to clip optimization across coordinate systems #2324

Closed

Commits on Jan 18, 2018

  1. Fix an issue with clip masks and segmentation

    When all clips are optimized away,  we may still need a clip mask when
    some of those clips were in a different coordinate system. This change
    ensures that this information is used to properly apply global clip
    masks for segmented primitives with this kind of clipping situation.
    
    Fixes #2294.
    mrobinson committed Jan 18, 2018
  2. Replace root coordinate space optimization

    This check is no longer necessarily true with the introduction of
    ClipChains, which make it harder to make assumptions about what the
    coordinate system of our clip chain looks like.
    
    Instead replace it with a similar check, which should cover more
    situations. When our clip chain only contains clips from our local
    coordinate system and they are all optimized away, just rely on the
    calculated local clip rect.
    mrobinson committed Jan 18, 2018
You can’t perform that action at this time.