Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async scene building. #2362

Merged
merged 18 commits into from Feb 22, 2018
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Address some review comments.

  • Loading branch information
nical committed Feb 21, 2018
commit 61bb29a405c78008d5588280c4406ca42bdf57a2
@@ -427,7 +427,7 @@ impl<'a> FlattenContext<'a> {
&mut self.id_to_index_mapper,
);

let epoch = *self.scene.pipeline_epochs.get(&iframe_pipeline_id).unwrap();
let epoch = self.scene.pipeline_epochs[&iframe_pipeline_id];
self.pipeline_epochs.push((iframe_pipeline_id, epoch));

let bounds = item.rect();
@@ -1113,7 +1113,7 @@ impl FrameContext {

let old_scrolling_states = self.reset();

let root_epoch = *scene.pipeline_epochs.get(&root_pipeline_id).unwrap();
let root_epoch = scene.pipeline_epochs[&root_pipeline_id];
self.pipeline_epoch_map.insert(root_pipeline_id, root_epoch);


@@ -1183,7 +1183,7 @@ impl FrameContext {
let window_size = request.view.window_size;
let device_pixel_scale = request.view.accumulated_scale_factor();

// We checked that the root pipeline is available on therender backend.
// We checked that the root pipeline is available on the render backend.
let root_pipeline_id = scene.root_pipeline_id.unwrap();
let root_pipeline = scene.pipelines.get(&root_pipeline_id).unwrap();

@@ -1194,7 +1194,7 @@ impl FrameContext {
let mut pipeline_epoch_map = FastHashMap::default();
let mut clip_scroll_tree = ClipScrollTree::new();

let root_epoch = *scene.pipeline_epochs.get(&root_pipeline_id).unwrap();
let root_epoch = scene.pipeline_epochs[&root_pipeline_id];
pipeline_epoch_map.insert(root_pipeline_id, root_epoch);

let frame_builder = {
@@ -760,7 +760,7 @@ impl RenderBackend {
}
}

return true;
true
}

fn update_document(
@@ -1275,7 +1275,8 @@ impl SceneBuilder {
}
SceneBuilderRequest::Stop => { return false; }
}
return true;

true
}

pub fn build_scene(&mut self, request: SceneRequest) -> BuiltScene {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.