Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async scene building. #2362

Merged
merged 18 commits into from Feb 22, 2018
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Don't use the scene builder thread by default (yet).

  • Loading branch information
nical committed Feb 21, 2018
commit e39e0e7ca8dc9faff954a8d9cf6c8fda483a6495
@@ -156,11 +156,22 @@ impl Transaction {
postfix_ops: Vec::new(),
resource_updates: ResourceUpdates::new(),
payloads: Vec::new(),
use_scene_builder_thread: true,
use_scene_builder_thread: false, // TODO: make this true by default.
generate_frame: false,
}
}

// TODO: better name?
pub fn skip_scene_builder(&mut self) {
self.use_scene_builder_thread = false;
}

// TODO: this is temporary, using the scene builder thread is the default for
// most transactions, and opt-in for specific cases like scrolling and async video.
pub fn use_scene_builder_thread(&mut self) {
self.use_scene_builder_thread = true;
}

pub fn is_empty(&self) -> bool {
!self.generate_frame &&
self.prefix_ops.is_empty() &&
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.