Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the desktop no longer show through when alpha blending is involved for borderless windows on the Mac. #237
+14
−6
Conversation
for borderless windows on the Mac. This was because the blend function was `GL_SRC_ALPHA`/`GL_ONE_MINUS_SRC_ALPHA` for both RGB and alpha, and that was incorrect for alpha, since a destination alpha of 1.0 and a source alpha < 1.0 should result in an alpha of 1.0.
|
cc @paulrouget |
|
Appears to work well here. |
|
Fix servo/servo#9877 |
|
@pcwalton This sounds right - could we just check that running against the mozilla/ reftests dir and webrender-demos doesn't introduce any regressions? |
|
@glennw Checked those tests. They seem fine. (Some of them fail for me, but I inspected them manually and they look fine. It looks like a problem with the harness, probably pre-existing and maybe Mac-specific.) |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 16, 2016
Make the desktop no longer show through when alpha blending is involved for borderless windows on the Mac. This was because the blend function was `GL_SRC_ALPHA`/`GL_ONE_MINUS_SRC_ALPHA` for both RGB and alpha, and that was incorrect for alpha, since a destination alpha of 1.0 and a source alpha < 1.0 should result in an alpha of 1.0. r? @glennw
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedMar 12, 2016
This was because the blend function was
GL_SRC_ALPHA/GL_ONE_MINUS_SRC_ALPHAfor both RGB and alpha, and thatwas incorrect for alpha, since a destination alpha of 1.0 and a source
alpha < 1.0 should result in an alpha of 1.0.
r? @glennw