Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for transform-origin and perspective-origin in wrench. #2378
Conversation
I added this for some perspective transform bugs I'll be working on this week. During that, I noticed that the output of the new perspective-origin reftest is incorrect - I'll raise a separate bug for that. I also modified the existing reftests that use perspective to explicitly set the perspective origin to 0, so that their behaviour is unaffected by this change. The default perspective origin is set to 50% of the bounds, which is what the default is in the CSS transforms spec.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 5, 2018
Add support for transform-origin and perspective-origin in wrench. I added this for some perspective transform bugs I'll be working on this week. During that, I noticed that the output of the new perspective-origin reftest is incorrect - I'll raise a separate bug for that. I also modified the existing reftests that use perspective to explicitly set the perspective origin to 0, so that their behaviour is unaffected by this change. The default perspective origin is set to 50% of the bounds, which is what the default is in the CSS transforms spec. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2378) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedFeb 4, 2018
•
edited by larsbergstrom
I added this for some perspective transform bugs I'll be working on
this week.
During that, I noticed that the output of the new perspective-origin
reftest is incorrect - I'll raise a separate bug for that.
I also modified the existing reftests that use perspective to
explicitly set the perspective origin to 0, so that their
behaviour is unaffected by this change. The default perspective
origin is set to 50% of the bounds, which is what the default
is in the CSS transforms spec.
This change is