Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd hit testing support for ClipChains from the API #2392
Merged
Conversation
Hit testing now has support for tests against items that were clipped by API-defined ClipChains. Both clipping ClipScrollNodes nodes and ClipChains are converted to pairs of ClipScrollNodes and ClipChains for purposes of the HitTester. This more-or-less matches the logical next step in ClipScrollTree design and makes the logic for HitTesting simpler. Fixes #2383.
|
This change also adds a rawtest which tests hit testing. The tests aren't totally complete yet, but we can add more as we go along. |
|
Reviewed 4 of 4 files at r1. Comments from Reviewable |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 7, 2018
Add hit testing support for ClipChains from the API Hit testing now has support for tests against items that were clipped by API-defined ClipChains. Both clipping ClipScrollNodes nodes and ClipChains are converted to pairs of ClipScrollNodes and ClipChains for purposes of the HitTester. This more-or-less matches the logical next step in ClipScrollTree design and makes the logic for HitTesting simpler. Fixes #2383. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2392) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedFeb 7, 2018
•
edited by larsbergstrom
Hit testing now has support for tests against items that were clipped by
API-defined ClipChains. Both clipping ClipScrollNodes nodes and
ClipChains are converted to pairs of ClipScrollNodes and ClipChains for
purposes of the HitTester. This more-or-less matches the logical next
step in ClipScrollTree design and makes the logic for HitTesting
simpler.
Fixes #2383.
This change is