Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upre-rasterize fast text shadows directly with the given shadow color #2393
Conversation
|
Just checking, this manages to do something special to color glyphs? (Emoji) |
|
Also could you make shadow-atomic strict again? |
|
This is why we still need to keep the shadow flag around on TextRunPrimitiveCpu, essentially to disambiguate that one remaining case. Otherwise, we wouldn't need it. |
|
@lsalzman |
|
Okay, back to linux-only for now then. |
|
@bors-servo r+ |
|
|
re-rasterize fast text shadows directly with the given shadow color It seems that in the wild people are expecting unblurred text shadows to be precisely the same as if the text is drawn with the shadow color. So long as we have to deal with subpixel anti-aliasing and preblending, it is not really possible to reuse the subpixel AA masks and satisfy those constraints. Thus, we have to go back to the old method of just re-rasterizing the text shadow AA masks with the font color being exactly the shadow color, or the preblending just gets messed up. This fixes issue #2384 and also the downstream Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1434029 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2393) <!-- Reviewable:end -->
|
|
lsalzman commentedFeb 7, 2018
•
edited
It seems that in the wild people are expecting unblurred text shadows to be precisely the same as if the text is drawn with the shadow color. So long as we have to deal with subpixel anti-aliasing and preblending, it is not really possible to reuse the subpixel AA masks and satisfy those constraints. Thus, we have to go back to the old method of just re-rasterizing the text shadow AA masks with the font color being exactly the shadow color, or the preblending just gets messed up.
This fixes issue #2384 and also the downstream Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1434029
This change is