Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix perspective-origin reftest. #2398
Merged
Conversation
|
r? @kvark or anyone I temporarily removed the fuzziness from this test, to see what CI fails with. It passes locally on my machine with no fuzziness now. We might still need a fuzz setting on CI, but it will hopefully be less. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 8, 2018
Fix perspective-origin reftest. I was misinterpreting the output of this test - I hadn't realized that in wrench the stretch-size defaults to the image dimensions, rather than the local rect dimensions. I modified the test to take account of this and it draws correctly now. Fixes #2379. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2398) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedFeb 8, 2018
•
edited by larsbergstrom
I was misinterpreting the output of this test - I hadn't realized
that in wrench the stretch-size defaults to the image dimensions,
rather than the local rect dimensions. I modified the test to
take account of this and it draws correctly now.
Fixes #2379.
This change is