Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTidy more files #2403
Merged
Tidy more files #2403
Conversation
Expand servo-tidy to include webrender_api/ and webrender/ (except the main source directory). The ordering rules for use statements seem a little capricious, but at least these will be in line with how Servo is formatted.
| @@ -11,14 +11,12 @@ extern crate webrender; | |||
| mod boilerplate; | |||
|
|
|||
| use boilerplate::{Example, HandyDandyRectBuilder}; | |||
| use rayon::Configuration as ThreadPoolConfig; | |||
| use rayon::ThreadPool; | |||
| use rayon::{Configuration as ThreadPoolConfig, ThreadPool}; | |||
This comment has been minimized.
This comment has been minimized.
kvark
Feb 9, 2018
Member
we really need to ensure that rustfmt is in agreement with servo tidy here, could you verify?
This comment has been minimized.
This comment has been minimized.
mrobinson
Feb 9, 2018
•
Author
Member
I ran rustfmt nightly on blob.rs and it made some changes. Those changes still ran cleanly through servo-tidy, so I think it's just that servo-tidy is more stringent than rustfmt currently.
|
ok, thanks @mrobinson ! |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 9, 2018
Tidy more files Expand servo-tidy to include webrender_api/ and webrender/ (except the main source directory). The ordering rules for use statements seem a little capricious, but at least these will be in line with how Servo is formatted. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2403) <!-- Reviewable:end -->
|
@kvark Thanks for the review! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedFeb 9, 2018
•
edited by larsbergstrom
Expand servo-tidy to include webrender_api/ and webrender/ (except the
main source directory). The ordering rules for use statements seem a
little capricious, but at least these will be in line with how Servo is
formatted.
This change is