Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProperly handle optimized ClipChain in custom ClipChain nodes #2455
Conversation
|
cc @staktrace |
|
The change seems fine - let's do a try run though before merging. |
|
|
When a node included in a ClipScrollNode ClipChain is optimized away, we need to ensure that custom ClipChains that rely on that node are using the original node and not one of the parents. In order to achieve this, we store a copy of the original ClipChainNode in the ClipScrollNode and use it when building custom ClipChains. Fixes #2388.
mrobinson
force-pushed the
mrobinson:custom-clip-chain-ancestors
branch
from
a9919dc
to
f32fb92
|
@glennw Thanks! I kicked off a Gecko try job here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=321e364a093eff86a5a73d5b722806e06bd8d220 |
|
Looks fairly green to me, thank you! |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 23, 2018
Properly handle optimized ClipChain in custom ClipChain nodes When a node included in a ClipScrollNode ClipChain is optimized away, we need to ensure that custom ClipChains that rely on that node are using the original node and not one of the parents. In order to achieve this, we store a copy of the original ClipChainNode in the ClipScrollNode and use it when building custom ClipChains. Fixes #2388. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2455) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedFeb 22, 2018
•
edited by larsbergstrom
When a node included in a ClipScrollNode ClipChain is optimized away, we need to
ensure that custom ClipChains that rely on that node are using the
original node and not one of the parents. In order to achieve this, we
store a copy of the original ClipChainNode in the ClipScrollNode and use
it when building custom ClipChains.
Fixes #2388.
This change is