Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEliminate FrameContext and merge it into Document #2456
Merged
Conversation
mrobinson
force-pushed the
mrobinson:remove-frame-context
branch
from
656d126
to
38f7579
|
Looks good to me! |
|
Reviewed 5 of 5 files at r1. Comments from Reviewable |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 22, 2018
Eliminate FrameContext and merge it into Document This greatly simplifies the way that Document and frame flattening interact and allows us to remove a duplicated method. This is part of fixing #2419. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2456) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedFeb 22, 2018
•
edited by larsbergstrom
This greatly simplifies the way that Document and frame flattening
interact and allows us to remove a duplicated method. This is part of
fixing #2419.
This change is