Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBe less strict when detecting 2D translations #2457
Merged
Conversation
We can avoid comparing directly against 1 here and use an epsilon to account for floating point error.
|
This is a suggestion from #2434. The Gecko try job for this is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fd18cae59eff15f670587663adaa43223b6793a |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 22, 2018
Be less strict when detecting 2D translations We can avoid comparing directly against 1 here and use an epsilon to account for floating point error. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2457) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedFeb 22, 2018
•
edited by larsbergstrom
We can avoid comparing directly against 1 here and use an epsilon to
account for floating point error.
This change is