Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for texture size #2459

Merged
merged 1 commit into from Feb 22, 2018
Merged

Check for texture size #2459

merged 1 commit into from Feb 22, 2018

Conversation

@kvark
Copy link
Member

kvark commented Feb 22, 2018 •
edited by larsbergstrom

This change is Reviewable
@kvark
Check for texture size
Loading status checks…
16cb2b1
@kvark kvark requested a review from glennw Feb 22, 2018
@kvark kvark mentioned this pull request Feb 22, 2018
Merged
@kvark
Copy link
Member Author

kvark commented Feb 22, 2018

It's not entirely clear how to gracefully handle this case, especially for GPU cache being rather sensitive. Some checks are still better than no checks though :)

(as per IRC)
@bors-servo r=glennw
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2018

📌 Commit 16cb2b1 has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2018

⌛ Testing commit 16cb2b1 with merge a057582...
bors-servo added a commit that referenced this pull request Feb 22, 2018
@bors-servo
Auto merge of #2459 - kvark:texture-size, r=glennw
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a057582 
Check for texture size

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2459)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2018

☀️ Test successful - status-appveyor, status-taskcluster, status-travis
Approved by: glennw
Pushing a057582 to master...
@bors-servo bors-servo merged commit 16cb2b1 into servo:master Feb 22, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:texture-size branch Feb 23, 2018
@Darkspirit Darkspirit mentioned this pull request Apr 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennw glennw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@kvark @bors-servo
You can’t perform that action at this time.