Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call init_transform_fs automatically in Brush framework #2476

Closed
wants to merge 1 commit into from
Closed

Call init_transform_fs automatically in Brush framework #2476

wants to merge 1 commit into from

Conversation

@kvark
Copy link
Member

kvark commented Feb 28, 2018 •
edited by larsbergstrom

(needs a try push)

This change is Reviewable
@kvark kvark force-pushed the kvark:init-transform-fs branch 2 times, most recently from 8b24b73 to 4b8219f Feb 28, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2018

☔ The latest upstream changes (presumably #2487) made this pull request unmergeable. Please resolve the merge conflicts.
@glennw
Copy link
Member

glennw commented Mar 14, 2018

@kvark Should this be kept open / updated?
@kvark
Copy link
Member Author

kvark commented Mar 14, 2018

IIRC, there was a Gecko reftest that I needed to investigate. I'll get back to it and revive this.
@kvark kvark force-pushed the kvark:init-transform-fs branch from 4b8219f to 165428b Mar 16, 2018
@kvark
Copy link
Member Author

kvark commented Mar 16, 2018

Rebased and updated. Let's see how the try push goes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=39f236e6bb48fd93d2c0f4fceca0ebe91c92bc95
@kvark kvark force-pushed the kvark:init-transform-fs branch from 165428b to 89a856f Mar 16, 2018
@glennw
Copy link
Member

glennw commented Mar 18, 2018

The try run looks good, I think - those two failues are from a previous box-shadow PR. There is one failing test on CI though. Otherwise, this looks good!
@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2018

☔ The latest upstream changes (presumably #2534) made this pull request unmergeable. Please resolve the merge conflicts.
@glennw
Copy link
Member

glennw commented Apr 12, 2018

Should we close this for now?
@kvark
Copy link
Member Author

kvark commented Apr 13, 2018

I was just rebasing and re-testing it, let's not close yet.
@kvark kvark force-pushed the kvark:init-transform-fs branch from 89a856f to 6d4b761 Apr 13, 2018
@kvark
Call init_transform_fs automatically in Brush framework
Loading status checks…
6d3af68
@kvark kvark force-pushed the kvark:init-transform-fs branch from 6d4b761 to 6d3af68 Apr 14, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2018

☔ The latest upstream changes (presumably #2621) made this pull request unmergeable. Please resolve the merge conflicts.
@gw3583
Copy link
Collaborator

gw3583 commented Jun 14, 2018

@kvark Should we keep this open?
@kvark
Copy link
Member Author

kvark commented Jun 14, 2018

@gw3583 I think this is still on the table, yes.
@gw3583
Copy link
Collaborator

gw3583 commented Jul 16, 2018

Closing for now, since this has been open a long time and has many conflicts. We can re-open when it's updated.
@gw3583 gw3583 closed this Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@kvark @bors-servo @glennw @gw3583
You can’t perform that action at this time.