Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appveyor config for Windows CI support. #248

Merged
merged 3 commits into from Mar 28, 2016
Merged

Add appveyor config for Windows CI support. #248

merged 3 commits into from Mar 28, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Mar 23, 2016

Fixes #246.

@frewsxcv frewsxcv force-pushed the appveyor branch 2 times, most recently from 45d2643 to d07be91 Mar 23, 2016
Fixes #246.
@frewsxcv frewsxcv force-pushed the appveyor branch from d07be91 to c6ab1df Mar 23, 2016
@frewsxcv
Copy link
Member Author

frewsxcv commented Mar 23, 2016

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 23, 2016

this lgtm

@glennw
Copy link
Member

glennw commented Mar 28, 2016

@bors-servo r=larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2016

📌 Commit c6ab1df has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2016

Testing commit c6ab1df with merge 9767007...

bors-servo added a commit that referenced this pull request Mar 28, 2016
Add appveyor config for Windows CI support.

Fixes #246.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2016

💔 Test failed - travis

@jdm
Copy link
Member

jdm commented Mar 28, 2016

src/render_backend.rs:211:79: 211:89 error: mismatched types:

 expected `offscreen_gl_context::gl_context_attributes::GLContextAttributes`,

    found `offscreen_gl_context::gl_context_attributes::GLContextAttributes`

(expected struct `offscreen_gl_context::gl_context_attributes::GLContextAttributes`,

    found a different struct `offscreen_gl_context::gl_context_attributes::GLContextAttributes`) [E0308]

src/render_backend.rs:211                                 match GLContext::<NativeGLContext>::new(size, attributes, ColorAttachmentType::Texture, Some(handle)) {

                                                                                                        ^~~~~~~~~~

src/render_backend.rs:211:79: 211:89 help: run `rustc --explain E0308` to see a detailed explanation

src/render_backend.rs:211:79: 211:89 note: Perhaps two different versions of crate `offscreen_gl_context` are being used?

src/render_backend.rs:211                                 match GLContext::<NativeGLContext>::new(size, attributes, ColorAttachmentType::Texture, Some(handle)) {

                                                                                                        ^~~~~~~~~~

src/render_backend.rs:240:43: 240:46 error: mismatched types:

 expected `&offscreen_gl_context::gl_context::GLContext<_>`,

    found `&offscreen_gl_context::gl_context::GLContext<offscreen_gl_context::platform::with_glx::native_gl_context::NativeGLContext>`

(expected struct `offscreen_gl_context::gl_context::GLContext`,

    found a different struct `offscreen_gl_context::gl_context::GLContext`) [E0308]

src/render_backend.rs:240                             command.apply(ctx);

                                                                    ^~~

src/render_backend.rs:240:43: 240:46 help: run `rustc --explain E0308` to see a detailed explanation

src/render_backend.rs:240:43: 240:46 note: Perhaps two different versions of crate `offscreen_gl_context` are being used?

src/render_backend.rs:240                             command.apply(ctx);

                                                                    ^~~

src/render_backend.rs:211:79: 211:89 error: mismatched types:

 expected `offscreen_gl_context::gl_context_attributes::GLContextAttributes`,

    found `offscreen_gl_context::gl_context_attributes::GLContextAttributes`

(expected struct `offscreen_gl_context::gl_context_attributes::GLContextAttributes`,

    found a different struct `offscreen_gl_context::gl_context_attributes::GLContextAttributes`) [E0308]

src/render_backend.rs:211                                 match GLContext::<NativeGLContext>::new(size, attributes, ColorAttachmentType::Texture, Some(handle)) {

                                                                                                        ^~~~~~~~~~

src/render_backend.rs:211:79: 211:89 help: run `rustc --explain E0308` to see a detailed explanation

src/render_backend.rs:211:79: 211:89 note: Perhaps two different versions of crate `offscreen_gl_context` are being used?

src/render_backend.rs:211                                 match GLContext::<NativeGLContext>::new(size, attributes, ColorAttachmentType::Texture, Some(handle)) {

                                                                                                        ^~~~~~~~~~

src/render_backend.rs:240:43: 240:46 error: mismatched types:

 expected `&offscreen_gl_context::gl_context::GLContext<_>`,

    found `&offscreen_gl_context::gl_context::GLContext<offscreen_gl_context::platform::with_glx::native_gl_context::NativeGLContext>`

(expected struct `offscreen_gl_context::gl_context::GLContext`,

    found a different struct `offscreen_gl_context::gl_context::GLContext`) [E0308]

src/render_backend.rs:240                             command.apply(ctx);

                                                                    ^~~

src/render_backend.rs:240:43: 240:46 help: run `rustc --explain E0308` to see a detailed explanation

src/render_backend.rs:240:43: 240:46 note: Perhaps two different versions of crate `offscreen_gl_context` are being used?

src/render_backend.rs:240                             command.apply(ctx);

                                                                    ^~~

error: aborting due to 2 previous errors

Build failed, waiting for other jobs to finish...

error: aborting due to 2 previous errors

error: Could not compile `webrender`.
@frewsxcv
Copy link
Member Author

frewsxcv commented Mar 28, 2016

Should I cherry pick #249?

@frewsxcv
Copy link
Member Author

frewsxcv commented Mar 28, 2016

Cherry-picked.

@frewsxcv
Copy link
Member Author

frewsxcv commented Mar 28, 2016

Looks like there's still an issue (fewer issues though). I don't have time to look into it right now. People can push to this branch if they want to try fixing it though.

@emilio
Copy link
Member

emilio commented Mar 28, 2016

@bors-servo r=gw,larsbergstrom

gw> emiliocobos: your wr/traits PRs all look fine to me, but there appear to be some CI / dependency issues preventing stuff landing there at the moment. Will look into that today or when back from PTO if no-one else does
emiliocobos> gw: If they look fine, frewsxcv should have just cherrypicked the last dependency problem (#249 and #250 should have passed but we had the appveyor hook configured but not running)
gw> emiliocobos: ok, cool

@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2016

📌 Commit 4495168 has been approved by gw,larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2016

Testing commit 4495168 with merge d352605...

bors-servo added a commit that referenced this pull request Mar 28, 2016
Add appveyor config for Windows CI support.

Fixes #246.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 4495168 into master Mar 28, 2016
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the appveyor branch Mar 28, 2016
nox added a commit to servo/servo that referenced this pull request Mar 31, 2016
Crate webrender is bumped to the first commit in servo/webrender#248.
Crate webrender_traits is bumped to the merge of servo/webrender_traits#21.
bors-servo added a commit to servo/servo that referenced this pull request Mar 31, 2016
Update webrender with crates.io's offscreen_gl_context (fixes #10296)

Crate webrender is bumped to the first commit in servo/webrender#248.
Crate webrender_traits is bumped to the merge of servo/webrender_traits#21.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10297)
<!-- Reviewable:end -->
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…context (fixes #10296) (from servo:the-offscreens); r=pcwalton

Crate webrender is bumped to the first commit in servo/webrender#248.
Crate webrender_traits is bumped to the merge of servo/webrender_traits#21.

Source-Repo: https://github.com/servo/servo
Source-Revision: 436f7316d97eabff4238c774a8ff7cc66fca08a0

UltraBlame original commit: 0475263dabee04d2fee38b887b18fefd79fa8df3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…context (fixes #10296) (from servo:the-offscreens); r=pcwalton

Crate webrender is bumped to the first commit in servo/webrender#248.
Crate webrender_traits is bumped to the merge of servo/webrender_traits#21.

Source-Repo: https://github.com/servo/servo
Source-Revision: 436f7316d97eabff4238c774a8ff7cc66fca08a0

UltraBlame original commit: 0475263dabee04d2fee38b887b18fefd79fa8df3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…context (fixes #10296) (from servo:the-offscreens); r=pcwalton

Crate webrender is bumped to the first commit in servo/webrender#248.
Crate webrender_traits is bumped to the merge of servo/webrender_traits#21.

Source-Repo: https://github.com/servo/servo
Source-Revision: 436f7316d97eabff4238c774a8ff7cc66fca08a0

UltraBlame original commit: 0475263dabee04d2fee38b887b18fefd79fa8df3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.