Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRename FrameState and FrameContext #2481
Merged
Conversation
|
r? @glennw or anyone. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 1, 2018
Rename FrameState and FrameContext Rename these to FrameBuildingState and FrameBuildingContext to make it clearer at what point in the lifecycle of a frame that these are used. The new names aren't perfect, but they hopefully make things a bit clearer (since we used Frame in so many places). This is part of #2419. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2481) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedMar 1, 2018
•
edited by larsbergstrom
Rename these to FrameBuildingState and FrameBuildingContext to make it
clearer at what point in the lifecycle of a frame that these are used.
The new names aren't perfect, but they hopefully make things a bit
clearer (since we used Frame in so many places).
This is part of #2419.
This change is