Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement the CSS `filter` property. #25
Merged
Conversation
src/render_backend.rs
Outdated
| @@ -328,6 +329,12 @@ impl Scene { | |||
| debug_assert!(self.render_target_stack.len() == 0); | |||
| self.pipeline_epoch_map.clear(); | |||
|
|
|||
| println!("reset"); | |||
This comment has been minimized.
This comment has been minimized.
src/render_backend.rs
Outdated
| @@ -579,7 +634,7 @@ impl Scene { | |||
| // push all visible draw lists into aabb tree | |||
| for (draw_list_index, flat_draw_list) in self.flat_draw_lists.iter_mut().enumerate() { | |||
| for (item_index, item) in flat_draw_list.draw_list.items.iter_mut().enumerate() { | |||
| assert!(item.node_index.is_none()); | |||
| //assert!(item.node_index.is_none()); | |||
This comment has been minimized.
This comment has been minimized.
src/renderer.rs
Outdated
| CompositionOp::Filter(LowLevelFilterOp::Grayscale(_)) | | ||
| CompositionOp::Filter(LowLevelFilterOp::HueRotate(_)) | | ||
| CompositionOp::Filter(LowLevelFilterOp::Invert(_)) | | ||
| CompositionOp::Filter(LowLevelFilterOp::Opacity(_)) | |
This comment has been minimized.
This comment has been minimized.
glennw
Oct 14, 2015
Member
Can't opacity (and perhaps some of the others) be done without grabbing the framebuffer, just as a normal opengl blend op?
(We can still merge it if that's the case - but let's add a TODO noting that there is an optimization available for some of these modes to use the fixed function blend ops).
The mechanism is largely the same as for `mix-blend-mode`. Known issues: * `drop-shadow` is unimplemented. * `blur` does not properly blur the edges. Both issues stem from the fact that we do not yet inflate bounding boxes for filters and `mix-blend-mode`.
|
Updated per comments. r? @glennw |
glennw
added a commit
that referenced
this pull request
Oct 15, 2015
Implement the CSS `filter` property.
nox
pushed a commit
to nox/webrender
that referenced
this pull request
Aug 6, 2016
webgl: Derive Debug on most types This will allow us creating more useful error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 14, 2015
The mechanism is largely the same as for
mix-blend-mode.Known issues:
drop-shadowis unimplemented.blurdoes not properly blur the edges.Both issues stem from the fact that we do not yet inflate bounding boxes for
filters and
mix-blend-mode.