Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip blurred and shadowed text with local clip rect #2500

Merged
merged 1 commit into from Mar 10, 2018
Merged

Clip blurred and shadowed text with local clip rect #2500

merged 1 commit into from Mar 10, 2018

Conversation

@mrobinson
Copy link
Member

mrobinson commented Mar 8, 2018 •
edited by larsbergstrom

Take into account the local clipping rectangle in the brush and caching
text shaders. This allows the blurred shadow of text to be properly
clipped.

Co-authored-by: Alexis Beingessner a.beingessner@gmail.com

This change is Reviewable
@mrobinson mrobinson requested a review from glennw Mar 8, 2018
@glennw
Copy link
Member

glennw commented Mar 8, 2018

Seems to fail reftests on CI. The change generally looks good to me, though we'll need a try run too once the CI issue is resolved.
@mrobinson
Copy link
Member Author

mrobinson commented Mar 8, 2018

Whoops. Here is the try job for this change: https://treeherder.mozilla.org/#/jobs?repo=try&revision=17f13c2ccb9742d5360e7457b9ccbbcc94b0e1bb

It seems that the new test is failing on the bots. It could be that the test needs to be fuzzed since it uses a blurred shadow. I know that other similar tests have a fuzz defined
@kvark
Copy link
Member

kvark commented Mar 8, 2018

@mrobinson FYI, Alexis is @gankro on github
@mrobinson
Copy link
Member Author

mrobinson commented Mar 8, 2018

@kvark Is there something different I could have done with the Co-author tag using @gankro's GitHub nick?
@glennw
Copy link
Member

glennw commented Mar 8, 2018 

REFTEST TEST-UNEXPECTED-FAIL | reftests/text/blurred-shadow-local-clip-rect.yaml == reftests/text/blurred-shadow-local-clip-rect.png | image comparison, max difference: 181, number of differing pixels: 4357

The max difference in this is 181, so it seems to be something other than a fuzziness issue.
@mrobinson
Copy link
Member Author

mrobinson commented Mar 9, 2018

It seems the issue here is that the rendered image is different on the bots. I have this issue with three others tests, also related to text rendering.
@mrobinson mrobinson force-pushed the mrobinson:fix-shadow-clipping branch 2 times, most recently from 606627f to 6940b48 Mar 9, 2018
@mrobinson @Gankra
Clip blurred and shadowed text with local clip rect
Loading status checks…
dcd60e8 
Take into account the local clipping rectangle in the brush and caching
text shaders. This allows the blurred shadow of text to be properly
clipped.

Co-authored-by: Alexis Beingessner <a.beingessner@gmail.com>
@mrobinson mrobinson force-pushed the mrobinson:fix-shadow-clipping branch from 6940b48 to dcd60e8 Mar 9, 2018
@mrobinson
Copy link
Member Author

mrobinson commented Mar 9, 2018

The test is passing now after:

  1. Getting the output image from the build bot.
  2. Running this test only on Linux.

This seems to be the norm for many of the text tests, so it seems their output is very fragile. I wonder how we can improve this situation.
@kvark
Copy link
Member

kvark commented Mar 9, 2018

@mrobinson oh, I didn't realize this is a github hook. TIL!
@Gankra
Copy link
Contributor

Gankra commented Mar 9, 2018

This should fix https://bugzilla.mozilla.org/show_bug.cgi?id=1401653 and unblock https://bugzilla.mozilla.org/show_bug.cgi?id=1403261
@glennw
Copy link
Member

glennw commented Mar 9, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2018

📌 Commit dcd60e8 has been approved by glennw
bors-servo added a commit that referenced this pull request Mar 9, 2018
@bors-servo
Auto merge of #2500 - mrobinson:fix-shadow-clipping, r=glennw
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
93f4f43 
Clip blurred and shadowed text with local clip rect

Take into account the local clipping rectangle in the brush and caching
text shaders. This allows the blurred shadow of text to be properly
clipped.

Co-authored-by: Alexis Beingessner <a.beingessner@gmail.com>

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2500)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2018

⌛ Testing commit dcd60e8 with merge 93f4f43...
@glennw
Copy link
Member

glennw commented Mar 9, 2018

@mrobinson Ah, I also have that problem with generating text reference images on my machine. I haven't had a chance to delve into the cause either.
@glennw
glennw approved these changes Mar 9, 2018
View changes
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2018

💔 Test failed - status-travis
@kvark
Copy link
Member

kvark commented Mar 10, 2018

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2018

⌛ Testing commit dcd60e8 with merge 6dea428...
bors-servo added a commit that referenced this pull request Mar 10, 2018
@bors-servo
Auto merge of #2500 - mrobinson:fix-shadow-clipping, r=glennw
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6dea428 
Clip blurred and shadowed text with local clip rect

Take into account the local clipping rectangle in the brush and caching
text shaders. This allows the blurred shadow of text to be properly
clipped.

Co-authored-by: Alexis Beingessner <a.beingessner@gmail.com>

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2500)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2018

☀️ Test successful - status-appveyor, status-taskcluster, status-travis
Approved by: glennw
Pushing 6dea428 to master...
@bors-servo bors-servo merged commit dcd60e8 into servo:master Mar 10, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@mrobinson mrobinson mentioned this pull request Mar 10, 2018
Closed
@mrobinson mrobinson deleted the mrobinson:fix-shadow-clipping branch Mar 10, 2018
@mrobinson
Copy link
Member Author

mrobinson commented Mar 10, 2018

Thanks for the reviews!
@Gankra Gankra mentioned this pull request Mar 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennw glennw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mrobinson @glennw @kvark @Gankra @bors-servo
You can’t perform that action at this time.