Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do the texel-uv-to-pixel-uv conversion in floating point instead of in integers. #253

Merged
merged 1 commit into from Mar 30, 2016

Conversation

@pcwalton
Copy link
Collaborator

pcwalton commented Mar 30, 2016

Before, the truncation rounded all texel uvs to zero, resulting in
unblurred glyphs overwriting whatever was at (0,0) in the texture cache!

Addresses servo/servo#10136.

r? @glennw

integers.

Before, the truncation rounded all texel uvs to zero, resulting in
unblurred glyphs overwriting whatever was at (0,0) in the texture cache!

Addresses servo/servo#10136.
@pcwalton
Copy link
Collaborator Author

pcwalton commented Mar 30, 2016

@bors-servo: r=glennw

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

📌 Commit 032f1e8 has been approved by glennw

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

Testing commit 032f1e8 with merge 871c57b...

bors-servo added a commit that referenced this pull request Mar 30, 2016
Do the texel-uv-to-pixel-uv conversion in floating point instead of in integers.

Before, the truncation rounded all texel uvs to zero, resulting in
unblurred glyphs overwriting whatever was at (0,0) in the texture cache!

Addresses servo/servo#10136.

r? @glennw
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 032f1e8 into servo:master Mar 30, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.