Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix brush_blend on SandyBridge iGPU #2530
Conversation
|
@bors-servo r+ |
|
|
|
hold on, I missed one thing |
|
(was missing the filter functions changed from |
|
|
|
Upon checking with @mstange , it appears that having the color matrix affecting alpha is only needed for SVG color filters, and we don't quite support it in WR anyway, and we'll need way more logic to support SVG filters (not covered by brush_blend). Thus, we figured the test case that modifies the alpha via color matrix needs to be removed. |
|
|
|
This still needs the test case removed. |
|
Should be good now. |
|
|
Fix brush_blend on SandyBridge iGPU Dividing by zero is not a good idea in GLSL. Also fixes #2088 since we are at it. r? @jrmuizel Edit: wiki entry - https://github.com/servo/webrender/wiki/Driver-issues#division-by-zero-on-sandybridge-in-the-fragment-shader <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2530) <!-- Reviewable:end -->
|
|
kvark commentedMar 15, 2018
•
edited
Dividing by zero is not a good idea in GLSL.
Also fixes #2088 since we are at it.
r? @jrmuizel
Edit: wiki entry - https://github.com/servo/webrender/wiki/Driver-issues#division-by-zero-on-sandybridge-in-the-fragment-shader
This change is