Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove the ratio_xy argument from complex radial gradients #2544
Conversation
This is another step toward removing complex radial gradients completely (#2439). A radius parameter is introduced to compute the ratio. Currently this new parameter duplicates some of the functionality of start-radius and end-radius, but once the calculation of these values moves to prim_store we can remove those as well.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 19, 2018
Remove the ratio_xy argument from complex radial gradients This is another step toward removing complex radial gradients completely (#2439). A radius parameter is introduced to compute the ratio. Currently this new parameter duplicates some of the functionality of start-radius and end-radius, but once the calculation of these values moves to prim_store we can remove those as well. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2544) <!-- Reviewable:end -->
|
|
1 similar comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedMar 19, 2018
•
edited by larsbergstrom
This is another step toward removing complex radial gradients completely
(#2439). A radius parameter is introduced to compute the ratio.
Currently this new parameter duplicates some of the functionality of
start-radius and end-radius, but once the calculation of these values
moves to prim_store we can remove those as well.
This change is