Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove complex radial gradient API #2548
Merged
Conversation
Instead of allowing complex radial gradients, denormalize the stops array when serializing display lists to YAML. We also store start and end offset instead of start and end radius. This allows us to denormalize the stops array in a more straight-forward way. This opens up more opportunities for optimizing the radial gradient shader. Fixes #2439.
|
The Gecko try job for this change is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f9f6111454442c4d0a381ad6d8d508833f6e725 |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 20, 2018
…t, r=glennw Remove complex radial gradient API Instead of allowing complex radial gradients, denormalize the stops array when serializing display lists to YAML. We also store start and end offset instead of start and end radius. This allows us to denormalize the stops array in a more straight-forward way. This opens up more opportunities for optimizing the radial gradient shader. Fixes #2439. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2548) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedMar 20, 2018
•
edited by larsbergstrom
Instead of allowing complex radial gradients, denormalize the stops
array when serializing display lists to YAML. We also store start and
end offset instead of start and end radius. This allows us to
denormalize the stops array in a more straight-forward way. This opens
up more opportunities for optimizing the radial gradient shader.
Fixes #2439.
This change is