Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle box-shadow stretch mode per-axis. #2563
Conversation
This is a crash fix for box shadows that have one axis which is very long, and one axis that is small. It's also an optimization for box-shadows that have one long and one short axis, since it allows drawing a minimal shadow rect in these cases. This is handled by having a stretch mode per-axis rather than one for the entire shadow primitive. Fixes #2561.
|
r? @mrobinson or anyone Pending try run here (have not checked results yet): |
|
Try run looks good. There are a couple of seemingly unrelated intermittents, but all the box-shadow reftests appear the same. |
|
r? @kvark |
|
Reviewed 9 of 9 files at r1. webrender/res/cs_clip_box_shadow.glsl, line 23 at r1 (raw file):
nit: could be webrender/res/cs_clip_box_shadow.glsl, line 77 at r1 (raw file):
somewhat unfortunate code duplication, can be addressed later Comments from Reviewable |
|
@bors-servo r+ |
|
|
Handle box-shadow stretch mode per-axis. This is a crash fix for box shadows that have one axis which is very long, and one axis that is small. It's also an optimization for box-shadows that have one long and one short axis, since it allows drawing a minimal shadow rect in these cases. This is handled by having a stretch mode per-axis rather than one for the entire shadow primitive. Fixes #2561. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2563) <!-- Reviewable:end -->
|
|
glennw commentedMar 23, 2018
•
edited by larsbergstrom
This is a crash fix for box shadows that have one axis which is
very long, and one axis that is small.
It's also an optimization for box-shadows that have one long and
one short axis, since it allows drawing a minimal shadow rect in
these cases. This is handled by having a stretch mode per-axis
rather than one for the entire shadow primitive.
Fixes #2561.
This change is