Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd reftest for #2584 #2586
Merged
add reftest for #2584 #2586
Conversation
result: expected:
|
|
cc #2584 |
|
Giving this a chance to sit in case someone more knowledgeable about the relevant subsystems sees something obvious. |
|
|
|
@gankro This should pass, now that the drop-shadow patch has landed. Just needs a rebase, then r=me. |
|
rebased |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 3, 2018
add reftest for #2584 (fails on master) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2586) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Gankra commentedMar 28, 2018
•
edited by larsbergstrom
(fails on master)
This change is