Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable segment path for Pictures, we don't support it yet. #2602
Conversation
We need a bit of extra work in batch.rs before pictures will be correctly added when they have a valid segmentation. For now, just disable segment building for pictures until we do that.
|
r? @kvark or anyone Pending try here: |
|
This is a fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1445723. |
|
Try run looks good. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 3, 2018
Disable segment path for Pictures, we don't support it yet. We need a bit of extra work in batch.rs before pictures will be correctly added when they have a valid segmentation. For now, just disable segment building for pictures until we do that. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2602) <!-- Reviewable:end -->
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedApr 3, 2018
•
edited by larsbergstrom
We need a bit of extra work in batch.rs before pictures will be
correctly added when they have a valid segmentation. For now,
just disable segment building for pictures until we do that.
This change is