Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix AA on ellipse clip code under some edge cases. #2604
Merged
Conversation
If the AA range is > 1.0, due to a specific transform, the inner pixels of a primitive that are not affected by the elliptical radii in a clip mask may end up with a signed distance of 1.0, which causes blending artifacts. Instead, initialize the default value for signed distance to the calculated AA range, which ensures we get a blend factor of 1.0 in such cases. Fixes #2576.
|
r? @kvark or anyone. I'll kick off a gecko try shortly. |
|
Try run looks good. |
|
truly a one-liner :) |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 4, 2018
Fix AA on ellipse clip code under some edge cases. If the AA range is > 1.0, due to a specific transform, the inner pixels of a primitive that are not affected by the elliptical radii in a clip mask may end up with a signed distance of 1.0, which causes blending artifacts. Instead, initialize the default value for signed distance to the calculated AA range, which ensures we get a blend factor of 1.0 in such cases. Fixes #2576. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2604) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedApr 4, 2018
•
edited by larsbergstrom
If the AA range is > 1.0, due to a specific transform, the inner
pixels of a primitive that are not affected by the elliptical
radii in a clip mask may end up with a signed distance of 1.0,
which causes blending artifacts.
Instead, initialize the default value for signed distance to
the calculated AA range, which ensures we get a blend factor
of 1.0 in such cases.
Fixes #2576.
This change is