Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Round up the stretch size #2615

Closed
wants to merge 1 commit into from
Closed

[WIP] Round up the stretch size #2615

wants to merge 1 commit into from

Conversation

@kvark
Copy link
Member

kvark commented Apr 5, 2018 •
edited by larsbergstrom

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1401665
Pending try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e138e9e5aa30bd5f1c40501c990a73dc056a60fe

This change is Reviewable
@kvark
Copy link
Member Author

kvark commented Apr 5, 2018

There is a failure in "file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/backgrounds/background-tiling-zoom-1.html", I'm looking into it.
@Darkspirit
Copy link

Darkspirit commented Apr 5, 2018 •
edited

Debian Testing, KDE, Radeon RX480, 2560x1440
mozregression --repo try --launch e138e9e5aa30bd5f1c40501c990a73dc056a60fe --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://bugzilla.mozilla.org/attachment.cgi?id=8910415|https://bugzilla.mozilla.org/attachment.cgi?id=8910430|https://bugzilla.mozilla.org/attachment.cgi?id=8916296|https://dev.terrax.net/"

screenshot_20180405_144017

One thin line is left.
Second column, try build: WR is sharper/coarser as non-WR at the place where the line was.
(I promise to replace this ugly PNG loading circle with an SVG.)
@kvark
Copy link
Member Author

kvark commented Apr 5, 2018

@Darkspirit wow, I don't know what to say... incredible analysis, thank you!
@kvark
Hack around non-rounded stretch size
Loading status checks…
bb9ebba
@kvark kvark force-pushed the kvark:tile-size branch from a2f4fb8 to bb9ebba Apr 5, 2018
@kvark kvark changed the title [WIP] Round up the tile size in the image shader [WIP] Round up the stretch size Apr 5, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2018

☔ The latest upstream changes (presumably #2619) made this pull request unmergeable. Please resolve the merge conflicts.
@kvark kvark mentioned this pull request Apr 12, 2018
Merged
@kvark
Copy link
Member Author

kvark commented May 4, 2018

To be resumed later
@kvark kvark closed this May 4, 2018
@kvark kvark deleted the kvark:tile-size branch Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kvark @Darkspirit @bors-servo
You can’t perform that action at this time.