Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport sampling from the render task cache in brush images. #2619
Conversation
|
This is related to the work in #2572 but since I am under the impression that the latter will take forever to land, I'm trying to separate whatever I can into independent pull requests. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 5, 2018
Support sampling from the render task cache in brush images. This PR adds support for sampling the render task cache in brush images, and test it out adds support for image sub rects in brush_image. The sub rects implementation is duplicated between the brush and non-brush primitives, but I think it's fine to live with this temporarily because if things go well the non-brush code path will go away soon and the way I am planning to support pre-rendering tile spacing will make the two code paths diverge. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2619) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedApr 5, 2018
•
edited by larsbergstrom
This PR adds support for sampling the render task cache in brush images, and test it out adds support for image sub rects in brush_image.
The sub rects implementation is duplicated between the brush and non-brush primitives, but I think it's fine to live with this temporarily because if things go well the non-brush code path will go away soon and the way I am planning to support pre-rendering tile spacing will make the two code paths diverge.
This change is