Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSeparate primitive shaders from clip shaders #2623
Conversation
|
Looks sane, thanks! |
|
|
|
Sounds good to me, could you document the constraints on the driver issues wiki page? It's not really a driver issue per se but it's in the bag if platform/backend/configuration specific issues that we don't necessarily catch locally. |
|
Thanks for taking a look! New wiki entry - https://github.com/servo/webrender/wiki/Driver-issues#2623-unused-vertex-attributes-in-spir-v @bors-servo r=glennw |
|
|
Separate primitive shaders from clip shaders Includes #2622 Note: this is not done because I'm bored. The problem Szeged team has bumped into is that `aDataX` attributes end up being used in the shaders they don't relate to (e.g. clip shaders). This isn't affecting GLSL but it does affect GLSL -> SPIRV -> XXX shader pipelines. The solution I came up with involves moving parts of `prim_shared` into separate shared modules, and turning `clip_shared` into a catch-all header of clip shades. Downsides: more shader modules (but not programs) to navigate between. Any suggestions on alternative solutions are welcome ;) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2623) <!-- Reviewable:end -->
|
|
kvark commentedApr 5, 2018
•
edited by larsbergstrom
Includes #2622
Note: this is not done because I'm bored.
The problem Szeged team has bumped into is that
aDataXattributes end up being used in the shaders they don't relate to (e.g. clip shaders). This isn't affecting GLSL but it does affect GLSL -> SPIRV -> XXX shader pipelines.The solution I came up with involves moving parts of
prim_sharedinto separate shared modules, and turningclip_sharedinto a catch-all header of clip shades.Downsides: more shader modules (but not programs) to navigate between.
Any suggestions on alternative solutions are welcome ;)
This change is