Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border edge checks #2630

Merged
merged 2 commits into from Apr 9, 2018
Merged

Border edge checks #2630

merged 2 commits into from Apr 9, 2018

Conversation

@kvark
Copy link
Member

kvark commented Apr 6, 2018 •
edited by larsbergstrom

This change prevents zero-sized edges from being produced by the frame builder and rendered.

This change is Reviewable
kvark added 2 commits Apr 6, 2018
@kvark
Avoid drawing empty border edges
199c72d
@kvark
Don't create empty border batches
Loading status checks…
9e0e926
@kvark kvark requested a review from glennw Apr 6, 2018
@kvark kvark mentioned this pull request Apr 6, 2018
Closed
@glennw
Copy link
Member

glennw commented Apr 8, 2018

I guess we'll need a try run for this.
@kvark
Copy link
Member Author

kvark commented Apr 9, 2018

@glennw I guess it has been reviewed? :)
Try push looks green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7b3a2d0386543d7e07ffca1f0ab45724d5acc64&selectedJob=172671868

@bors-servo r=glennw
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2018

📌 Commit 9e0e926 has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2018

⌛ Testing commit 9e0e926 with merge 9574ba2...
bors-servo added a commit that referenced this pull request Apr 9, 2018
@bors-servo
Auto merge of #2630 - kvark:border-edge, r=glennw
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9574ba2 
Border edge checks

This change prevents zero-sized edges from being produced by the frame builder and rendered.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2630)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: glennw
Pushing 9574ba2 to master...
@bors-servo bors-servo merged commit 9e0e926 into servo:master Apr 9, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:border-edge branch Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennw glennw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kvark @glennw @bors-servo
You can’t perform that action at this time.