Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't get stuck in overscroll #264
Merged
+16
−10
Conversation
|
r? @pcwalton |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 25, 2016
Don't get stuck in overscroll * Never trigger overscroll bounce when overscroll is disabled. This fixes a bug where rounding could cause a layer to enter overscroll even if CAN_OVERFLOW is false, and then get stuck. * Run the overscroll animation all the way to the destination, then stop animating. This fixes a bug where a layer could get "stuck" in overscroll because it gets within 0.1 of the edge and then stops.
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Apr 25, 2016
Don't get stuck in overscroll * Never trigger overscroll bounce when overscroll is disabled. This fixes a bug where rounding could cause a layer to enter overscroll even if CAN_OVERFLOW is false, and then get stuck. * Run the overscroll animation all the way to the destination, then stop animating. This fixes a bug where a layer could get "stuck" in overscroll because it gets within 0.1 of the edge and then stops.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedApr 19, 2016