Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reftest for mask clips on stacking contexts, closes #1957 #2646

Merged
merged 1 commit into from Apr 11, 2018

Conversation

@Gankra
Copy link
Contributor

Gankra commented Apr 11, 2018

This was made possible by #2600. I had to make the test a bit fuzzy
since the reference uses floating point color, while the test uses integer color.
They're visually indistinguishable, though.


This change is Reviewable

This was made possible by #2600. I had to make the test a bit fuzzy
since the reference uses floating point color, while the test uses integer color.
They're visually indistinguishable, though.
@kvark
Copy link
Member

kvark commented Apr 11, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

📌 Commit ae30f65 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

Testing commit ae30f65 with merge 9017e5b...

bors-servo added a commit that referenced this pull request Apr 11, 2018
add reftest for mask clips on stacking contexts, closes #1957

This was made possible by #2600. I had to make the test a bit fuzzy
since the reference uses floating point color, while the test uses integer color.
They're visually indistinguishable, though.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2646)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 9017e5b to master...

@bors-servo bors-servo merged commit ae30f65 into servo:master Apr 11, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.